Author Archives: ianmcorvidae

Server update, 2014-08-18

A day late with putting this out, due to some sleep mis-scheduling on the part of yours truly, but we’re back with another release! This release includes a variety of small bug fixes and improvements, as well as a reworking of the track parser, which now supports a more complete set of options to control exactly which information is parsed and which is updated in the tracklist. Thanks to bitmap, chirlu, ianmcorvidae, nikki, and reosarevok for their work on this release!

The git tag for this release is v-2014-08-18.

Full list of issues in this release:

Bug

  • [MBS-7753] – Username displays wrongly on area pages
  • [MBS-7799] – unable to add artist as database entry
  • [MBS-7800] – Last.fm URL cleanup doesn’t work for .br and .com
  • [MBS-7804] – URL cleanup for places doesn’t validate links to Discogs or Other Databases
  • [MBS-7805] – series-rels inc parameter doesn’t work since WebServiceInc was not updated

Improvement

  • [MBS-5925] – Show whether you’re subscribed to a collection on the collection overview
  • [MBS-6705] – Move “No linguistic content” lyrics language from “Other” to “Frequently used”
  • [MBS-7270] – The option to parse vinyl track numbers can be confusing
  • [MBS-7749] – Rap Genius is now Genius
  • [MBS-7797] – When editors are not referenced in the DB, delete their rows entirely rather than renaming to Deleted Editor #N
  • [MBS-7798] – Release relationship editor needs a loading indicator
  • [MBS-7803] – Add reports for entities with annotations

New Feature

  • [MBS-3730] – Feature parity: Please re-add the ability to parse only times
  • [MBS-3732] – Feature parity: Please re-add the ability to parse only titles
  • [MBS-4921] – Add a [No lyrics] option to works language

Task

  • [MBS-7785] – Update ESTER to account for the merger of its branches

Server update, 2014-07-21

A small release this week, as a lot of work has been happening on larger things in progress and on other projects. Still a few various bugs and some improvements aimed at improving the performance of the release and relationship editors. Thanks to chirlu, bitmap, and ianmcorvidae for their work on this release.

The git tag for this release is v-2014-07-21.

Full ticket list.

Bug

  • [MBS-7594] – Changing a track’s recording doesn’t properly clear the old recording from cache
  • [MBS-7680] – Add relationship dialog prepopulated with too many attributes
  • [MBS-7717] – Discogs URL cleanup doesn’t remove trailing dash
  • [MBS-7720] – Release group ratings disappeared from release sidebar
  • [MBS-7736] – "Merge release" edit not closing
  • [MBS-7747] – Missing/duplicate results in inline direct search
  • [MBS-7748] – Merging areas doesn’t update places

Improvement

  • [MBS-7135] – Remove "view" part from Discogs master URLs
  • [MBS-7689] – mini-relationship-editor UI is unbearably slow when there are many items
  • [MBS-7741] – Reordering tracks/mediums in the release editor can be slow

Server update, 2014-07-07

Another fortnight, another release. A bit quiet this time for the summer and some vacations and holidays, but a few bugfixes, some refactoring, and the addition of browse by area in /ws/2. navap also found a security issue which allowed editing of collections by any user, which is not listed below. Thanks to nikki, bitmap, navap, and chirlu for their work on this release!

The git tag for this release is v-2014-07-07.

Bug

  • [MBS-7617] – Changing a URL’s link type on a series edit page doesn’t trigger any validation
  • [MBS-7672] – Relationship type dropdown is not ordered correctly
  • [MBS-7673] – Entity types are inconsistently ordered when adding a relationship
  • [MBS-7684] – Spurious closing </span> tags
  • [MBS-7691] – OZON.ru URLs are automatically edited to add partner=musicbrainz
  • [MBS-7696] – “This attribute type is only used for grouping, please select a subtype” when editing works
  • [MBS-7698] – Release editor asks for confirmation to leave even if there are no changes (but the release has URL relationships)
  • [MBS-7700] – Work attribute types are not sorted alphabetically
  • [MBS-7703] – Unused urls in l_series_url are not removed
  • [MBS-7707] – Work attributes are not sorted in the sidebar
  • [MBS-7713] – Percent signs not escaped in Wikipedia extract link to Wikipedia

Improvement

  • [MBS-7694] – link areas to other entities in the webservice

Task

  • [MBS-7702] – Reduce the duplication in link_* macros
  • [MBS-7704] – Factor out entity treeness into a role

Server update, 2014-06-09

A day late in actually releasing it, but we have a new server release! Assorted bug fixes, improvements, and refactoring make up this release. Thanks to the MetaBrainz team and supplementary work from chirlu, reosarevok, and nikki. The git tag for this release is v-2014-06-09. The full list of fixed tickets:

Bug

  • [MBS-4669] – Webservice returns an ASIN that was added in a voted down edit
  • [MBS-5526] – Diff highlighting messes up descriptions in edit relationship type edits
  • [MBS-7455] – ISE for /ws/js/edit/preview: Error: Could not create MusicBrainz::Server::Edit::Release::DeleteReleaseLabel edit
  • [MBS-7552] – Entering a Series that requires disambig. changes the part of-numbering
  • [MBS-7574] – Regression. Can’t fill release group field by pasting URL
  • [MBS-7583] – Nonfunctional relationship page for instruments
  • [MBS-7584] – Double “Relationships” heading on label relationships page
  • [MBS-7585] – Missing series in subscriptions page
  • [MBS-7588] – ARRAY(0x1987d1c8) shown on add work edit
  • [MBS-7589] – Edit types in edit search are sorted in ASCII order
  • [MBS-7590] – Search results for instruments should strip markup from the description
  • [MBS-7604] – Whitespace+invalid character at the end of a string causes an ISE
  • [MBS-7608] – Internal server error looking up CD TOC with too large offsets
  • [MBS-7609] – “Refine this search” links breaks for entities with no entity filter in the edit search
  • [MBS-7611] – Internal server error loading annotation revision
  • [MBS-7614] – Relationship attributes are validated against the old link type
  • [MBS-7615] – Changes to URLs only are treated as no change
  • [MBS-7624] – Possible to create edits which add two unknown country release events
  • [MBS-7633] – l(‘Series’) is ambiguous
  • [MBS-7636] – Regression + data corruption: edit page swaps the direction of relationships

Improvement

  • [MBS-1377] – Turn relationships with multiple instrument/vocal attributes into multiple relationships
  • [MBS-7541] – Add Series to the statistics
  • [MBS-7542] – Add instruments to statistics
  • [MBS-7595] – Discid edits should show release artist
  • [MBS-7618] – fullexport generation must complete before replication packets are copied, resulting in temporary but several-hour gaps in the available replication packets
  • [MBS-7621] – Treat non-free-text work attribute types with no options as grouping types
  • [MBS-7631] – Make instrument relationships link back to the instrument entity pages

New Feature

  • [MBS-4825] – Normalize blogspot URLs

Task

  • [MBS-7499] – Add vkdb.jp to the otherdbs whitelist
  • [MBS-7571] – Factor out lists of entities in the code

Server update, 2014-05-26

We’re back with another release on the heels of our schema change. This release includes some fixes that were hot-fixed to the production servers late the other week as well as some that have gone through the usual beta process. As such, most of the changes have to do with new or changed features of that release, plus some assorted refactoring and other bugfixes. Thanks to chirlu, nikki, and the rest of the MetaBrainz team for their hard work on this release!

Happy series editing!

The git tag for this release is v-2014-05-26.

The full list of fixed tickets, as usual:

Bug

  • [MBS-6181] – Deleted editors may be nominated for auto-editorship
  • [MBS-6309] – Search results don’t have a score column anymore after a few pages
  • [MBS-7354] – Internal Server Error in mini relationship editor when a relationship has been removed
  • [MBS-7513] – Uploading PDF cover art requires the user to switch to the “All files” filetype in the file selection dialog
  • [MBS-7514] – New accounts may be called “Deleted Editor #nnn”
  • [MBS-7516] – Age of 0 not displayed in user profiles
  • [MBS-7519] – “PDF file” labels displayed on top of image previews
  • [MBS-7530] – Caught exception in MusicBrainz::Server::Controller::Series->add_alias “The edit could not be created.
  • [MBS-7532] – ISE: Undefined value when relating Release Groups to an ordered Series
  • [MBS-7533] – Can’t create a new series from inline search
  • [MBS-7538] – Regression: Not possible to edit URL relationship attributes
  • [MBS-7539] – series. numbering elements is not auto-edit while setting automatic is
  • [MBS-7543] – “Cancel” does not cancel changes made in mini-relationship-editor for instrument-performer ARs
  • [MBS-7544] – Grouping link types are selectable in the release editor
  • [MBS-7545] – Release editor creates empty URL edits if you just change the release name
  • [MBS-7548] – Automatic series ordering doesn’t work correctly
  • [MBS-7549] – Regression: Release Editor URL seeding does not work anymore
  • [MBS-7550] – Regression: Editor search is broken
  • [MBS-7555] – ISE when changing series order numbering
  • [MBS-7556] – URL cleanup broken on edit URL pages
  • [MBS-7558] – Relationship-editor shows “The end date cannot preceed the begin date” incorrectly
  • [MBS-7559] – Sort name guess case is missing from series alias pages
  • [MBS-7561] – Relationship editor doesn’t show the count of selected recordings
  • [MBS-7562] – Regression: Error trying to unset a label in “edit release label”
  • [MBS-7563] – Multiple failures on “edit label”
  • [MBS-7570] – Add series and instruments as linkable entities in annotations
  • [MBS-7576] – Not possible to add relationships to a non-label from a label edit page
  • [MBS-7579] – Error while trying to add a release
  • [MBS-7593] – Regression: Seeding URLs to mini-relationship editor is broken
  • [MBS-7597] – Replacing recording-work relationship in relationship editor fails
  • [MBS-7599] – Relationship editor doesn’t load relationships for some recordings
  • [MBS-7600] – Firefox: “Edit Note” does not show Add Release Label if the annotation gets removed
  • [MBS-7603] – Replication trigger missing for link_attribute_text_value table

Improvement

  • [MBS-7493] – Redirected MBID pages, slave/beta servers, and non-preferred scheme should use rel=canonical to link to the main site
  • [MBS-7517] – Deleted editors should appear as “deleted”, not as “Limited User”
  • [MBS-7567] – Provide “copy/sort” bubble for all alias sortnames
  • [MBS-7575] – Support creating/editing URL relationships with the /relationship-editor endpoint
  • [MBS-7596] – The relationship editor dialog should work on a copy of the relationship until the dialog is accepted
  • [MBS-7619] – admin/config.sh means configuration is split between files (and since checked-in complicates customization)

Task

  • [MBS-7547] – Remove MAC authentication for WS

Brief downtime this Friday/Saturday, at 2 UTC (19 PDT/22 EDT/4 CEST)

As some of you with slave databases may have noticed, we made a slight error and excluded some of the new tables from our schema change in replication (tracked by MBS-7603).

Luckily, the tables in question are presently quite small, meaning that if we act now we can add them without needing a formal schema change release (by simply replicating out the changes). Less luckily, this process requires taking some very heavy locks on the ‘series’ database table, so we’ve chosen to have a small amount of downtime to run the script, at (or shortly after) the time mentioned in the title, which also gives us a chance to restart our database server to incorporate some extensions we’d intended but failed to add during the schema change release last week.

We don’t foresee this process taking more than a few minutes, and no action should be necessary for downstream data users.

Server upgrade and schema change, 2014-05-14

Hello again! This fortnight, as we’ve mentioned among the past few posts, is our twice-annual schema change release! This means that we’ve got some big changes, as well as special upgrade instructions.

In the former category, we’ve added support for two new entities: Series and Instruments, each of which is exactly what it sounds like. We’ve also done some various cleanup (tables missing from replication, making some attribute-style tables (e.g., label types) trees, and more properly orderable, removing unuseful sortnames). In non-schema-change fixes, we’ve fixed some merging for Artist Credits, show Area names after Places routinely, and perhaps most excitingly, added smaller versions of the relationship editor for other entities. It’s now possible to add relationships to any entity from most entity edit pages, expanding on our previous addition of URL editing!

As far as upgrading:

  1. Ensure you’ve replicated up to the most recent replication packet available with the old schema. (if you’re not sure, run ./admin/replication/LoadReplicationChanges and see what it tells you).
  2. Take down the web server running MusicBrainz, if you’re running a web server.
  3. Turn off cron jobs if you are automatically updating the database via cron jobs.
  4. Make sure your REPLICATION_TYPE setting is RT_SLAVE
  5. Switch to the new code with git fetch origin followed by git checkout v-2014-05-14-schema-change
  6. Run ./upgrade.sh (or carton exec -Ilib -- ./upgrade.sh if you’re using carton, with older installs).
  7. Set DB_SCHEMA_SEQUENCE to 20 in lib/DBDefs.pm
  8. Turn cron jobs back on, if needed.
  9. Restart the MusicBrainz web server, if applicable. It’s also recommended you restart memcached.

The git tag for this release, as mentioned above in the instructions, is v-2014-05-14-schema-change.

Full release notes, as usual:

Bug

  • [MBS-5978] – Replication feed is missing release_tag
  • [MBS-6709] – “None” is no longer the last Packaging type after adding Book and Cassette Case
  • [MBS-7482] – Artist merge with AC renaming does not merge identical ACs

Improvement

  • [MBS-2410] – Label types not a tree anymore
  • [MBS-2714] – Add support for Series.
  • [MBS-5897] – Make it possible to see edit JSON in the case of an ISE or poor data display
  • [MBS-6144] – Remove the apparently-unused script_language table
  • [MBS-6602] – Remove sortnames from areas
  • [MBS-6603] – Remove sortnames from labels
  • [MBS-6651] – Make it possible to disable dates for relationship types
  • [MBS-6886] – Display area after place names
  • [MBS-6887] – Model coordinates without nullable latitude and longitude
  • [MBS-7205] – Link types should track assumed cardinality
  • [MBS-7411] – Don’t require disambiguation comments for places from different areas
  • [MBS-7470] – Merging/combining RG types (primary/secondary) is unintuitive

New Feature

  • [MBS-3674] – Make instruments entities
  • [MBS-6234] – Add a relationship editor to artists, labels, recordings, release-groups, places, areas and works

Task

  • [MBS-7441] – Check non-replicated changes to DB that have happened since last schema change